From 784ac42a0f05608e3d9c5e15246dbf76ce9e3d51 Mon Sep 17 00:00:00 2001 From: Adrian Kummerlaender Date: Tue, 1 Jul 2014 20:54:02 +0200 Subject: Removed unnecessary template member methods from TranformationFacade * neither the constructor nor the generate member methods need to be templatized ** only supported "output" argument is now a reference to a "std::basic_ostream" instance ** the caller is responsible for e.g. writing the output to disk * this was done to simplify the basic interface of InputXSLT * removed "default_params" testcase along with default parameter generation ** this feature is neither used nor required --- ixslt.cc | 9 ++++- src/transformation_facade.cc | 45 ++++++++++--------------- src/transformation_facade.h | 60 +++++----------------------------- test/default_params/reference.xml | 5 --- test/default_params/transformation.xsl | 23 ------------- test/read_directory/reference.xml | 3 -- 6 files changed, 34 insertions(+), 111 deletions(-) delete mode 100644 test/default_params/reference.xml delete mode 100644 test/default_params/transformation.xsl diff --git a/ixslt.cc b/ixslt.cc index b1671b3..abc7e1a 100644 --- a/ixslt.cc +++ b/ixslt.cc @@ -1,5 +1,6 @@ #include "boost/optional.hpp" #include "boost/program_options.hpp" +#include #include #include @@ -117,9 +118,15 @@ bool process(const boost::program_options::variables_map& variables) { try { if ( variables.count("target") ) { - transformation->generate( + boost::filesystem::ofstream file( variables["target"].as() ); + + if ( file.is_open() ) { + transformation->generate(file); + } else { + return false; + } } else { transformation->generate(std::cout); } diff --git a/src/transformation_facade.cc b/src/transformation_facade.cc index 97b17bb..9d248b8 100644 --- a/src/transformation_facade.cc +++ b/src/transformation_facade.cc @@ -3,10 +3,6 @@ #include #include -#include "boost/filesystem.hpp" - -#include - #include "support/xerces_string_guard.h" namespace InputXSLT { @@ -70,39 +66,34 @@ WarningCapacitor::warning_cache_ptr TransformationFacade::getCachedWarnings() { return this->warning_capacitor_.discharge(); } +void TransformationFacade::generate(std::basic_ostream& targetStream) { + StylesheetParameterGuard guard(this->transformer_); + + this->generate(targetStream, guard); +} + void TransformationFacade::generate( - const std::string& targetPath, - StylesheetParameterGuard& parameters + std::basic_ostream& targetStream, + const StylesheetParameterGuard::map& parameters ) { - const boost::filesystem::path targetPathHelper( - boost::filesystem::absolute(targetPath) - ); - - parameters.set( - "target-file", targetPathHelper.filename().string() - ); - parameters.set( - "parent-directory", targetPathHelper.parent_path().filename().string() - ); + StylesheetParameterGuard guard(this->transformer_, parameters); - this->generate( - xalan::XSLTResultTarget(targetPath.data()), - parameters - ); + this->generate(targetStream, guard); } void TransformationFacade::generate( std::basic_ostream& targetStream, - StylesheetParameterGuard& parameters + const xalan::XObjectPtr& parameter ) { - this->generate( - xalan::XSLTResultTarget(targetStream), - parameters - ); + StylesheetParameterGuard guard(this->transformer_); + guard.set("parameters", parameter); + + this->generate(targetStream, guard); } + void TransformationFacade::generate( - xalan::XSLTResultTarget&& outputTarget, + std::basic_ostream& targetStream, StylesheetParameterGuard& ) { ErrorCapacitor errorCapacitor(&this->error_multiplexer_); @@ -110,7 +101,7 @@ void TransformationFacade::generate( this->transformer_.transform( *(this->input_), this->transformation_, - outputTarget + targetStream ); errorCapacitor.discharge(); diff --git a/src/transformation_facade.h b/src/transformation_facade.h index eb134cd..ca57de4 100644 --- a/src/transformation_facade.h +++ b/src/transformation_facade.h @@ -5,6 +5,7 @@ #include #include +#include #include #include "common.h" @@ -26,9 +27,6 @@ class TransformationFacade { Arguments&&... ); - template - TransformationFacade(Arguments&&..., IncludeEntityResolver*); - TransformationFacade( xalan::XSLTInputSource, IncludeEntityResolver* @@ -40,14 +38,9 @@ class TransformationFacade { IncludeEntityResolver* ); - template - void generate(Target&); - - template - void generate(Target&, const StylesheetParameterGuard::map&); - - template - void generate(Target&, const xalan::XObjectPtr&); + void generate(std::basic_ostream&); + void generate(std::basic_ostream&, const StylesheetParameterGuard::map&); + void generate(std::basic_ostream&, const xalan::XObjectPtr&); WarningCapacitor::warning_cache_ptr getCachedWarnings(); @@ -59,9 +52,10 @@ class TransformationFacade { ErrorMultiplexer error_multiplexer_; WarningCapacitor warning_capacitor_; - void generate(const std::string&, StylesheetParameterGuard&); - void generate(std::basic_ostream&, StylesheetParameterGuard&); - void generate(xalan::XSLTResultTarget&&, StylesheetParameterGuard&); + void generate( + std::basic_ostream&, + StylesheetParameterGuard& + ); }; @@ -84,44 +78,6 @@ auto TransformationFacade::try_create( } } -template -TransformationFacade::TransformationFacade( - Arguments&&... arguments, - IncludeEntityResolver* resolver -): - TransformationFacade( - xalan::XSLTInputSource(std::forward(arguments))..., - resolver - ) { } - -template -void TransformationFacade::generate(Target& target) { - StylesheetParameterGuard guard(this->transformer_); - - this->generate(target, guard); -} - -template -void TransformationFacade::generate( - Target& target, - const StylesheetParameterGuard::map& parameters -) { - StylesheetParameterGuard guard(this->transformer_, parameters); - - this->generate(target, guard); -} - -template -void TransformationFacade::generate( - Target& target, - const xalan::XObjectPtr& parameter -) { - StylesheetParameterGuard guard(this->transformer_); - guard.set("parameters", parameter); - - this->generate(target, guard); -} - } #endif // INPUTXSLT_SRC_TRANSFORMATION_FACADE_H_ diff --git a/test/default_params/reference.xml b/test/default_params/reference.xml deleted file mode 100644 index 566064b..0000000 --- a/test/default_params/reference.xml +++ /dev/null @@ -1,5 +0,0 @@ - - -actual.xml -default_params - diff --git a/test/default_params/transformation.xsl b/test/default_params/transformation.xsl deleted file mode 100644 index 54cf57e..0000000 --- a/test/default_params/transformation.xsl +++ /dev/null @@ -1,23 +0,0 @@ - - - - - - - - - - - - - - - - - - diff --git a/test/read_directory/reference.xml b/test/read_directory/reference.xml index b2eac35..7d63a85 100644 --- a/test/read_directory/reference.xml +++ b/test/read_directory/reference.xml @@ -11,9 +11,6 @@ common -default_params - - external_text_formatter -- cgit v1.2.3