From 085935ddd577b0c65b4330318b5ba20492d93126 Mon Sep 17 00:00:00 2001
From: Adrian Kummerländer
Date: Sat, 24 May 2014 13:59:42 +0200
Subject: Implemented ResultNodeFacade as a DOM node construction helper *
 wraps result node construction and appends it to root node on destruction *
 offers a simpler interface for common node construction patterns * simplifies
 result node construction in all external function implementations ** most
 noticeable in FunctionReadDirectory * expanded FunctionReadDirectory result
 nodes by name, extension, and full-path nodes

---
 src/function/read_directory.cc | 40 +++++++++++-----------------------------
 1 file changed, 11 insertions(+), 29 deletions(-)

(limited to 'src/function/read_directory.cc')

diff --git a/src/function/read_directory.cc b/src/function/read_directory.cc
index 215a59e..a3995ec 100644
--- a/src/function/read_directory.cc
+++ b/src/function/read_directory.cc
@@ -3,9 +3,9 @@
 #include <xercesc/dom/DOMDocument.hpp>
 #include <xercesc/dom/DOMImplementation.hpp>
 #include <xercesc/dom/DOMElement.hpp>
-#include <xercesc/dom/DOMText.hpp>
 
 #include "support/xerces_string_guard.h"
+#include "support/dom/result_node_facade.h"
 
 namespace InputXSLT {
 
@@ -33,52 +33,34 @@ xercesc::DOMDocument* FunctionReadDirectory::constructDocument(
 		fsContext.iterate(
 			directoryPath,
 			[&domDocument, &rootNode](const boost::filesystem::path& p) {
-			xercesc::DOMElement* const itemNode(
-				domDocument->createElement(*XercesStringGuard<XMLCh>("result"))
-			);
+			ResultNodeFacade result(domDocument, rootNode, "result");
 
 			switch ( boost::filesystem::status(p).type() ) {
 				case boost::filesystem::regular_file: {
-					itemNode->setAttribute(
-						*XercesStringGuard<XMLCh>("type"),
-						*XercesStringGuard<XMLCh>("file")
-					);
+					result.setAttribute("type", "file");
+					result.setValueNode("name", p.stem().string());
+					result.setValueNode("extension", p.extension().string());
 
 					break;
 				};
 				case boost::filesystem::directory_file: {
-					itemNode->setAttribute(
-						*XercesStringGuard<XMLCh>("type"),
-						*XercesStringGuard<XMLCh>("directory")
-					);
+					result.setAttribute("type", "directory");
+					result.setValueNode("name", p.filename().string());
 
 					break;
 				};
 				default: {
-					itemNode->setAttribute(
-						*XercesStringGuard<XMLCh>("type"),
-						*XercesStringGuard<XMLCh>("misc")
-					);
+					result.setAttribute("type", "misc");
+					result.setValueNode("name", p.filename().string());
 
 					break;
 				};
 			}
 
-			xercesc::DOMText* const textNode(
-				domDocument->createTextNode(
-					*XercesStringGuard<XMLCh>(p.filename().string())
-				)
-			);
-
-			itemNode->appendChild(textNode);
-			rootNode->appendChild(itemNode);
+			result.setValueNode("full", boost::filesystem::canonical(p).string());
 		});
 	} else {
-		xercesc::DOMElement* const resultNode(
-			domDocument->createElement(*XercesStringGuard<XMLCh>("error"))
-		);
-
-		rootNode->appendChild(resultNode);
+		ResultNodeFacade result(domDocument, rootNode, "error");
 	}
 
 	return domDocument;
-- 
cgit v1.2.3