diff options
author | Adrian Kummerlaender | 2015-08-22 20:56:21 +0200 |
---|---|---|
committer | Adrian Kummerlaender | 2015-08-22 20:56:21 +0200 |
commit | d58de87c338415457c6ff9f546f707a51ca42493 (patch) | |
tree | f025e00f7114563d6657cd98a71685f95283e4fe /src/SettingsHandler.qml | |
parent | a1e95832074ef46e3f97a8086d8a3a821fa92521 (diff) | |
download | MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.tar MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.tar.gz MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.tar.bz2 MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.tar.lz MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.tar.xz MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.tar.zst MetaTerm-d58de87c338415457c6ff9f546f707a51ca42493.zip |
Replaced unnecessary `eval` calls in settings getter and setter
Diffstat (limited to 'src/SettingsHandler.qml')
-rw-r--r-- | src/SettingsHandler.qml | 43 |
1 files changed, 8 insertions, 35 deletions
diff --git a/src/SettingsHandler.qml b/src/SettingsHandler.qml index f281da1..fd13473 100644 --- a/src/SettingsHandler.qml +++ b/src/SettingsHandler.qml @@ -2,46 +2,19 @@ import QtQuick 2.0 import Qt.labs.settings 1.0 QtObject { - function getSetter(category, name) { - try { - var type = typeof eval(category + '.' + name); - - switch ( type ) { - case 'undefined': { - throw new ReferenceError(); - break; - } - case 'string': { - return function(value) { - return eval(category + '.' + name + ' = "' + value + '"'); - } - break; - } - default: { - return function(value) { - return eval(category + '.' + name + ' = ' + value); - } - break; - } - } - } - catch (exception) { + function read(category, name) { + if ( typeof this[category][name] === 'undefined' ) { throw category + '.' + name + ' doesnt exist.'; + } else { + return this[category][name]; } } - function read(category, name) { - try { - var value = eval(category + '.' + name); - - if ( typeof value === 'undefined' ) { - throw new ReferenceError(); - } else { - return value; - } - } - catch (exception) { + function set(category, name, value) { + if ( typeof this[category][name] === 'undefined' ) { throw category + '.' + name + ' doesnt exist.'; + } else { + this[category][name] = value; } } |