Implemented ResultNodeFacade as a DOM node construction helper

* wraps result node construction and appends it to root node on destruction
* offers a simpler interface for common node construction patterns
* simplifies result node construction in all external function implementations
** most noticeable in FunctionReadDirectory
* expanded FunctionReadDirectory result nodes by name, extension, and full-path nodes

1 files changed, 6 insertions, 23 deletions

diff --git a/src/function/read_file.cc b/src/function/read_file.cc
index 1a870a6..87423ab 100644
--- a/src/function/read_file.cc
+++ b/src/function/read_file.cc
@@ -3,11 +3,11 @@
 #include <xercesc/dom/DOMDocument.hpp>
 #include <xercesc/dom/DOMImplementation.hpp>
 #include <xercesc/dom/DOMElement.hpp>
-#include <xercesc/dom/DOMText.hpp>
 
 #include "boost/filesystem/fstream.hpp"
 
 #include "support/xerces_string_guard.h"
+#include "support/dom/result_node_facade.h"
 
 namespace {
 
@@ -51,29 +51,12 @@ xercesc::DOMDocument* FunctionReadFile::constructDocument(
 	);
 
 	if ( boost::filesystem::is_regular_file(filePath) ) {
-		xercesc::DOMElement* const resultNode(
-			domDocument->createElement(*XercesStringGuard<XMLCh>("result"))
-		);
-
-		resultNode->setAttribute(
-			*XercesStringGuard<XMLCh>("name"),
-			*XercesStringGuard<XMLCh>(filePath.filename().string())
-		);
-
-		xercesc::DOMText* const resultTextNode(
-			domDocument->createTextNode(
-				*XercesStringGuard<XMLCh>(readFile(filePath))
-			)
-		);
-
-		resultNode->appendChild(resultTextNode);
-		rootNode->appendChild(resultNode);
-	} else {
-		xercesc::DOMElement* const resultNode(
-			domDocument->createElement(*XercesStringGuard<XMLCh>("error"))
-		);
+		ResultNodeFacade result(domDocument, rootNode, "result");
 
-		rootNode->appendChild(resultNode);
+		result.setAttribute("name", filePath.filename().string());
+		result.setContent(readFile(filePath));
+	} else {
+		ResultNodeFacade result(domDocument, rootNode, "error");
 	}
 
 	return domDocument;